Skip to content

gh-145633: amend dae85c4d939 (refine notes on non-IEEE platforms)#145845

Open
skirpichev wants to merge 6 commits intopython:mainfrom
skirpichev:dae85c4d939-amend-docs
Open

gh-145633: amend dae85c4d939 (refine notes on non-IEEE platforms)#145845
skirpichev wants to merge 6 commits intopython:mainfrom
skirpichev:dae85c4d939-amend-docs

Conversation

@skirpichev
Copy link
Member

@skirpichev skirpichev commented Mar 12, 2026

  • we don't specify what happens on non-IEEE platforms
  • use rather PY_LITTLE_ENDIAN to get native endianness
  • mention that unpack functions don't fail in CPython
  • mention that PyFloat_Pack8 doesn't fail in CPython

📚 Documentation preview 📚: https://cpython-previews--145845.org.readthedocs.build/

* we don't specify what happens on non-IEEE platforms
* use rather PY_LITTLE_ENDIAN to get native endianness
* mention that unpack functions don't fail in CPython
* mention that PyFloat_Pack8 doesn't fail in CPython
@skirpichev
Copy link
Member Author

N.B: shouldn't be backported.

Maybe it's better to document first the PY_LITTLE_ENDIAN macro and then just reference it.

@skirpichev
Copy link
Member Author

СС @StanFromIreland

Copy link
Member

@StanFromIreland StanFromIreland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some little grammar things.

Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting review docs Documentation in the Doc dir skip news

Projects

Status: Todo

Development

Successfully merging this pull request may close these issues.

2 participants